This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Support parsing raw literals in UniValue #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laanwj also mentioned this change would be useful to have in bitcoin: bitcoin/bitcoin#9028 (comment) |
|
Yes, this would be useful, we work around this with an ugly hack right now (this is not passing the tests though!). |
ryanofsky
force-pushed
the
raw-literals
branch
from
1f4c300 to
4be8209
Compare
|
@ryanofsky Make sure to add those to the |
Fixes following test failures in https://github.com/nst/JSONTestSuite: bitcoin SHOULD_HAVE_PASSED y_structure_lonely_negative_real.json bitcoin SHOULD_HAVE_PASSED y_structure_lonely_string.json bitcoin SHOULD_HAVE_PASSED y_structure_lonely_false.json bitcoin SHOULD_HAVE_PASSED y_structure_lonely_null.json bitcoin SHOULD_HAVE_PASSED y_string_space.json bitcoin SHOULD_HAVE_PASSED y_structure_string_empty.json bitcoin SHOULD_HAVE_PASSED y_structure_lonely_int.json bitcoin SHOULD_HAVE_PASSED y_structure_lonely_true.json
ryanofsky
force-pushed
the
raw-literals
branch
from
4be8209 to
0bb1439
Compare
|
Thanks, updated Makefile.am. |
ryanofsky
force-pushed
the
raw-literals
branch
from
d6736c5 to
0bb1439
Compare
|
This PR, take by itself, introduces an unterminated-string bug at the core of the parser. Usefully, the next PR - #32 - fixes this bug. In the future, we want to avoid this split-submission, as it impacts git bisect. |
stickies-v
added a commit
to stickies-v/bitcoin
that referenced
this pull request
Jan 18, 2023
Since jgarzik/univalue#31, UniValue::read() can now parse raw literals directly, so there is no more need to wrap them into an array first.
stickies-v
added a commit
to stickies-v/bitcoin
that referenced
this pull request
Mar 4, 2023
Since jgarzik/univalue#31, UniValue::read() can now parse raw literals directly, so there is no more need to wrap them into an array first.
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Aug 27, 2023
Since jgarzik/univalue#31, UniValue::read() can now parse raw literals directly, so there is no more need to wrap them into an array first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes following test failures in https://github.com/nst/JSONTestSuite
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_negative_real.json
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_string.json
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_false.json
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_null.json
bitcoin SHOULD_HAVE_PASSED y_string_space.json
bitcoin SHOULD_HAVE_PASSED y_structure_string_empty.json
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_int.json
bitcoin SHOULD_HAVE_PASSED y_structure_lonely_true.json